-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(setting): Migrate OCM / OCS provider tests to SetupCheck #43607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ffcfb4
to
47d3b01
Compare
come-nc
previously requested changes
Feb 19, 2024
33 tasks
839e065
to
81d06b4
Compare
e6ac052
to
0b9e267
Compare
Resolved all comments, please re-review :) |
skjnldsv
approved these changes
Feb 27, 2024
- enh(setting): Migrate OCM / OCS provider tests to SetupCheck
+ feat(setting): Migrate OCM / OCS provider tests to SetupCheck |
come-nc
approved these changes
Feb 27, 2024
Co-authored-by: Ferdinand Thiessen <[email protected]> Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
0b9e267
to
2e8c9f2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the ocs-provider and ocm-provider from legacy to SetupCheck.
Checklist